Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dimmer] blurring dimmable leaves z-index stacking side effects #371

Merged

Conversation

lubber-de
Copy link
Member

Description

Thanks to @mayfield for the Fix (me being a lazy dude kindly copied parts of his issue text 😄 here)

For reference: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context

The use of a filter CSS property will impose z-index stacking rules for an element. As such, when using a blurring modal dimmer there are side effects left over from having a filter property on the non-dimmed content.

This leads to unexpected stacking behavior for elements that would otherwise not have z-index stacking rules applied to them. One example being the use of menus with dropdowns following the open/close of a blurred modal.

Testcase

http://jsfiddle.net/ncoa89yf/2/

  • Remove the CSS and open the top dropdown to see the issue
  • use the button to proove the transform filter is still animating (because the startfilter is changed in the PR)

Screenshots

Before

image

After

image

More screenshots in the original SUI issue below

Closes

Semantic-Org/Semantic-UI#5416

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 8, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 8, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit dbb7ad3 into fomantic:develop Jan 11, 2019
@lubber-de lubber-de deleted the fix/5416/blurring_dimmer_zindex_impact branch January 11, 2019 09:09
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 11, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 11, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants