[Modal] Prevent closing the modal when webkit scrollbar has been dragged #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside without closing the modal
lubber-de
added
type/bug
lubber-de
added
state/awaiting-docs
lubber-de
added
state/has-docs
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #431 (comment) by @ko2in, a modal gets closed when a webkit-custom scrollbar of the dimmer has been dragged
It seems to be only happening on webkit because of the custom scrollbar. The event system still recognizes the dimmer as target.
The new option
scrollbarWidthby default has the same value as the@customScrollbarWidthvalue fromsite.less. I initially wanted to calculate the scrollbar-Width at runtime via javascript, but it turns out this is not possible, because webkit does not return a width difference if a custom scrollbar is used. (that probably also the reason why the event still receognized the dimmer when clicking on the scrollbar)I think, using the same value as the webkit scrollbar width is the more reliable solution.
Testcase
Drag the dimmers scrollbar and watch how ...
Broken
... the modal closes
http://jsfiddle.net/7qa1upwf/2/
Fixed
.. the modal stays
http://jsfiddle.net/hvf4w2ap/