Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Support inverted colors #455

Merged
merged 3 commits into from
Feb 11, 2019
Merged

[Card] Support inverted colors #455

merged 3 commits into from
Feb 11, 2019

Conversation

lubber-de
Copy link
Member

Description

An inverted card did not support any color. It was always overridden by the default inverted gray.

Testcase

https://jsfiddle.net/3sjmfoew/

Closes

#454

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Feb 2, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 2, 2019
@lubber-de lubber-de mentioned this pull request Feb 2, 2019
Closed
y0hami
y0hami approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 23b9594 into fomantic:develop Feb 11, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Feb 20, 2019
@lubber-de lubber-de deleted the fix/454/inverted_card_colors branch February 20, 2019 14:23
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 20, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lubber-de @ColinFrick @y0hami