Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Last right item in a menu inside a container misses right border #480

Merged

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 11, 2019

Description

Having right items in a menu inside a container misses a final right border just like there is a left border for the very left item.

Testcase

Result-view has to be at least a width of 768px to see the outer borders
Remove CSS to see the difference
http://jsfiddle.net/s693qbct/

Screenshot

Before

image

After

image

Closes

Semantic-Org/Semantic-UI#3332

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Feb 11, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.7.x milestone Feb 12, 2019
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit ab2a277 into fomantic:develop Feb 20, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 20, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 20, 2019
@lubber-de lubber-de deleted the fix/3332/container_right_menu_border branch February 20, 2019 14:06
@y0hami y0hami mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants