Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] onHide was called twice #481

Merged
merged 1 commit into from
Feb 20, 2019
Merged

[Popup] onHide was called twice #481

merged 1 commit into from
Feb 20, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 11, 2019 •
edited
Loading

Description

The onHide event in the popup module was called twice.

  • First at the hide behavior (where it is correct)
  • Second right after the first call again in the module.animate.hide call and this is only called from the hide method mentioned before

Obviously an old copy/paste bug. In comparison to onShow this has now the same flow logic after applying the fix.

Testcase

  • Click on the little button to show the Popup
  • Click again to hide it and watch the console:

Wrong

onHide is shown twice
http://jsfiddle.net/bm1gzosv

Correct

onHide is shown once
http://jsfiddle.net/bm1gzosv/1/

Closes

Semantic-Org/Semantic-UI#4722
Semantic-Org/Semantic-UI#4752

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Feb 11, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 11, 2019
This was referenced Feb 11, 2019
Open
Closed
y0hami
y0hami approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 794a8b8 into fomantic:develop Feb 20, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 20, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 20, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@lubber-de lubber-de deleted the fix/4722/popup_double_onhide_call branch April 2, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami