Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Disabled items in tabular menus had same color as normal items #490

Merged

Conversation

lubber-de
Copy link
Member

Description

A disabled item in a tabular menu got the same color as a normal item. For normal or secondary menus is appears as expected.

Testcase

https://jsfiddle.net/o6mpnjL1/2/

Screenshot (when possible)

Before After
image image

Closes

Semantic-Org/Semantic-UI#3178
Semantic-Org/Semantic-UI#3578

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Feb 14, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 14, 2019
@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Feb 14, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 35ccf2d into fomantic:develop Feb 20, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 20, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 20, 2019
@lubber-de lubber-de deleted the fix/3178/disabled_tabbed_menu_item branch February 20, 2019 13:19
@y0hami y0hami mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants