Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Always show list when clicked on icon, regardless of minCharacter setting #510

Merged

Conversation

lubber-de
Copy link
Member

Description

Whenever a minCharacter setting > 0 was set, it was not possible to open the whole dropdown list anymore by clicking on the dropdown icon. (as it was in SUI)

Testcase

Broken

https://jsfiddle.net/1fvrphsa/2/

Fixed

https://jsfiddle.net/nkhg3cs8/

Closes

#496

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Feb 21, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 21, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 1a5ff2c into fomantic:develop Feb 25, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 25, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 25, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
@lubber-de lubber-de deleted the fix/496/dropdown_always_open_on_iconclick branch April 2, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants