Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] Adjustable shortyear to century calculation #527

Merged
merged 1 commit into from
Feb 28, 2019
Merged

[Calendar] Adjustable shortyear to century calculation #527

merged 1 commit into from
Feb 28, 2019

Conversation

lubber-de
Copy link
Member

Description

This PR adds the ability to adjust the calculation of entered shortyears to the belonging century by adding two new options

// default values to stay backward compatible to current behavior
currentCentury: 2000,
centuryBreak: 60,

Testcase

https://jsfiddle.net/7mhLw321/

Screenshot

calendar_century

Closes

#514

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Feb 27, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 27, 2019
@lubber-de lubber-de mentioned this pull request Feb 27, 2019
Closed
y0hami
y0hami approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit d06348e into fomantic:develop Feb 28, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 28, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 28, 2019
@lubber-de lubber-de mentioned this pull request Feb 28, 2019
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Feb 28, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
@lubber-de lubber-de deleted the feat/514/calendar_century_shortyear branch April 2, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @prudho @y0hami