Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Formvalidation] Safari was not showing error message #558

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[Formvalidation] Safari was not showing error message #558

merged 1 commit into from
Mar 12, 2019

Conversation

lubber-de
Copy link
Member

Description

Because of an unclear CSS definition for :empty and :not(:empty), Safari was never displaying any error message on form validation

Testcase

https://jsfiddle.net/43kLfupd/5/

  • Open in Safari
  • Click on "Login" -> Error Message below the form appears as expected
  • Remove the CSS Block
  • Re-Run the jsfiddle
  • Click on "Login" -> Error Message is not shown

Closes

#557
Semantic-Org/Semantic-UI#6668

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Mar 10, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Mar 10, 2019
This was referenced Mar 10, 2019
Closed
Open
y0hami
y0hami approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Mar 11, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 12, 2019
@y0hami y0hami merged commit c177443 into fomantic:develop Mar 12, 2019
@lubber-de lubber-de deleted the fix/557/safari_empty_bug branch March 26, 2019 13:38
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
This was referenced Dec 11, 2019
Closed
Closed
@lubber-de lubber-de mentioned this pull request Aug 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami