-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call _get_registries() in __init__ of PkgCompat.jl #2815
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/j-fu/Pluto.jl", rev="fix_registry_init")
julia> using Pluto |
It seems that this interfers with precompilation
Thanks! Can you check the PR files for unwanted changes? |
I think this is a longer story, as precompilation would have to be refactored, it calls RegistryInstances.reachable_registries() as well. In the moment it is switched off in order to see what else could happen. I can try to get a more comprehensive refactoring. I did run with a patched Pkg in order to see if it works. As a result I get what is in the screenshot, so it seems that there is still another issue: |
…d in fonsp#2810 (comment) This should be replaced by ```julia public function complete_remote_package end ``` in Pkg.REPLMode.
…ss during precompilation
For the I think it may make sense to make a PR to Pkg which marks internal things used by Pluto as |
IOBuffer.data is of type Memory since 1.11, and has no resize! method.
Now it works with dev'd HTTP.jl - the difference seems to be just one commit which also appears to be about the new Memory type: JuliaWeb/HTTP.jl@040cf0a Not sure though if returning a view is a good idea. Will need through testing. As for the Pkg stuff: I would go with @balenamiaa's hack implemented here and fix the Pkg stuff in a different PR when the public interface issues have been resolved. |
Guess it remains to wait now for a new release of HTTP.jl ... |
Still need JuliaWeb/HTTP.jl@040cf0a to be released
Still need JuliaWeb/HTTP.jl@040cf0a to be released, see JuliaWeb/HTTP.jl#1154 |
worked locally now under 1.6, 1.11.0-alpha1 and nigthly. |
Thanks! Let's work on the method table problems in another PR... |
The method table issue is here #2840 |
Thanks again @j-fu ! The other issue was only on Julia 1.12 (nightly), I now changed our CI to run the 1.11 preview and 1.12 nightly separately: fabde1f The new issue was caused by a change in Julia specifically meant to improve Pluto support! Super cool :) JuliaLang/julia#53415 |
See https://docs.julialang.org/en/v1/manual/modules/#Module-initialization-and-precompilation
Probably solved part of #2810