Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call _get_registries() in __init__ of PkgCompat.jl #2815

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Feb 18, 2024

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/j-fu/Pluto.jl", rev="fix_registry_init")
julia> using Pluto

It seems that this interfers with precompilation
@fonsp
Copy link
Owner

fonsp commented Feb 19, 2024

Thanks! Can you check the PR files for unwanted changes?

@fonsp fonsp added the package manager Pluto's built-in package manager label Feb 19, 2024
@j-fu
Copy link
Contributor Author

j-fu commented Feb 19, 2024

I think this is a longer story, as precompilation would have to be refactored, it calls RegistryInstances.reachable_registries() as well.

In the moment it is switched off in order to see what else could happen. I can try to get a more comprehensive refactoring.

I did run with a patched Pkg in order to see if it works. As a result I get what is in the screenshot, so it seems that there is still another issue:

tryagain

@j-fu
Copy link
Contributor Author

j-fu commented Feb 20, 2024

Ok what do we have now on nightly ?

  • the "Connection reset" problem goes away whe using dev'd HTTP.jl
  • In the notebook we get the following (for each notebook cell):
    no-resize

@j-fu
Copy link
Contributor Author

j-fu commented Feb 20, 2024

For the complete_remote_package problem I used the band-aid proposed in
#2810 (comment)

I think it may make sense to make a PR to Pkg which marks internal things used by Pluto as public in Julia 1.11 sense, making these public interface.

@j-fu
Copy link
Contributor Author

j-fu commented Feb 21, 2024

Ah, nicer stactrace now :)

no-resize2

IOBuffer.data is of type Memory since 1.11, and has no resize! method.
@j-fu
Copy link
Contributor Author

j-fu commented Feb 21, 2024

Now it works with dev'd HTTP.jl - the difference seems to be just one commit which also appears to be about the new Memory type: JuliaWeb/HTTP.jl@040cf0a

Not sure though if returning a view is a good idea. Will need through testing.

As for the Pkg stuff: I would go with @balenamiaa's hack implemented here and fix the Pkg stuff in a different PR when the public interface issues have been resolved.

@j-fu
Copy link
Contributor Author

j-fu commented Feb 26, 2024

Guess it remains to wait now for a new release of HTTP.jl ...

@j-fu
Copy link
Contributor Author

j-fu commented Mar 2, 2024

Still need JuliaWeb/HTTP.jl@040cf0a to be released, see JuliaWeb/HTTP.jl#1154

@j-fu
Copy link
Contributor Author

j-fu commented Mar 4, 2024

worked locally now under 1.6, 1.11.0-alpha1 and nigthly.

@fonsp
Copy link
Owner

fonsp commented Mar 4, 2024

Thanks! Let's work on the method table problems in another PR...

@fonsp fonsp merged commit 0cd6436 into fonsp:main Mar 4, 2024
10 of 14 checks passed
@fonsp
Copy link
Owner

fonsp commented Mar 5, 2024

The method table issue is here #2840

@fonsp
Copy link
Owner

fonsp commented Mar 5, 2024

Thanks again @j-fu ! The other issue was only on Julia 1.12 (nightly), I now changed our CI to run the 1.11 preview and 1.12 nightly separately: fabde1f

The new issue was caused by a change in Julia specifically meant to improve Pluto support! Super cool :) JuliaLang/julia#53415

@fonsp fonsp linked an issue Mar 11, 2024 that may be closed by this pull request
@fonsp fonsp mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package manager Pluto's built-in package manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompilation problem on 1.11 with complete_remote_package
2 participants