Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced nikud under double-yud and double-vov digraphs #16

Closed
markhdavid opened this issue Mar 17, 2023 · 4 comments
Closed

Misplaced nikud under double-yud and double-vov digraphs #16

markhdavid opened this issue Mar 17, 2023 · 4 comments

Comments

@markhdavid
Copy link

This font renders digraphs double-yud (Unicode Character “װ” (U+05F0) ; Name: Hebrew Ligature Yiddish Double Vav) and double-vov (Unicode Character “ײ” (U+05F2) ; Name: Hebrew Ligature Yiddish Double Yod), primarily used for Yiddish, such that nikud that's supposed to be centered under a character get put under the second subletter of the digraph. So a nikud like pasekh, tsere, segol, et al, is centered under the 2nd yud of double-yud and under 2nd vov of double-vov. That's wrong. Nikud is supposed to be centered with respect to both elements of the digraph. That's how these work. That's the whole point of why you need these digraphs. If you wanted the nikud centered under the second character of the digraph, you wouldn't need a digraph: you'd put out two separate characters with the nikud following the second character in the character sequence and unambiguously intended to be centered under that second character.

Here's a sample text for which I'll attach a screen shot of Google Fonts preview showing wrong rendering: װֶעלְכֶע | װֶעלְן | זײַן | רײַך
Google Fonts Frank Ruhl - bad double-yud and double-vov digraphs - Screen Shot 2023-03-17 at 4 26 01 PM

@markhdavid
Copy link
Author

For comparison here is a screen shot of the same preview text in the Google font named Arimo.
Arimo font with double-yud and double-vov with nikud at Google Fonts - Screen Shot 2023-03-21 at 5 52 40 PM

markhdavid added a commit to markhdavid/frankruhllibre that referenced this issue Mar 26, 2023
fontef#16)

Change double-yud, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE YOD (ײ),
and double-vov, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE VAV (װ), as
follows:

(1) set subCategory explicitly to "Other", based on advice by
@simoncozens in a Google Fonts issue here:
google/fonts#6062

and

(2) add "bottom" anchors, positioned as follows:

  - Y pos is 0;

  - X pos is halfway between where the "bottom" anchor of each
    component character glyph G would be if laid side by side,
    computed as

      (X pos of "bottom" anchor of G
       + set width of G
       + X pos of "bottom" anchor of G)
      divided by 2

All changes are reflected in this new version of

  sources/FrankRuhlLibre.glyphs

Note: this was hand-tested by generating just a few font files and
viewing in FontBook, but I leave it to upstream developers to perform
the the full build based on this source change.
markhdavid added a commit to markhdavid/frankruhllibre that referenced this issue Mar 27, 2023
fontef#16)

Change double-yud, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE YOD (ײ),
and double-vov, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE VAV (װ), to
correct horizontal placement under them of Hebrew diacritic ("nikud"),
as follows:

(1) set subCategory explicitly to "Other", based on advice by
@simoncozens in a Google Fonts issue here:
google/fonts#6062

and

(2) add "bottom" anchors, positioned as follows:

  - Y pos is 0;

  - X pos is halfway between where the "bottom" anchor of each
    component character glyph G would be if laid side by side,
    computed as

      (X pos of "bottom" anchor of G
       + set width of G
       + X pos of "bottom" anchor of G)
      divided by 2

All changes are reflected in this new version of

  sources/FrankRuhlLibre.glyphs

Note: this was hand-tested by generating just a few font files and
viewing in FontBook, but I leave it to upstream developers to perform
the the full build based on this source change.
fontef added a commit that referenced this issue Mar 29, 2023
Convert RTL kerning from Glyphs 2 to 3
Correct VavYod ligature (#17)
Correct placing of Niqqud in Yiddish ligatures (#16)
Correct overlapping Niqqud issue in Final Kaf (#14)
@fontef fontef closed this as completed Mar 29, 2023
@fontef
Copy link
Owner

fontef commented Mar 29, 2023

@emmamarichal Can you please help us re-generate the font files based on the latest fixes?

@emmamarichal
Copy link
Contributor

Hi @fontef!
Yes sure. The issues you solved are the same that in the @markhdavid's PRs?
Just to know if these PRs should be closed or merged.

Tell me when all is good and I'll start to review. I'm going to open an issue to update the font :)

@fontef
Copy link
Owner

fontef commented Mar 29, 2023

Hi @emmamarichal!
@markhdavid’s PRs should be closed.

All good, you can update the font :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants