Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced nikud under double-yud and double-vov digraphs #17

Closed
markhdavid opened this issue Mar 28, 2023 · 4 comments
Closed

Misplaced nikud under double-yud and double-vov digraphs #17

markhdavid opened this issue Mar 28, 2023 · 4 comments

Comments

@markhdavid
Copy link

This font renders digraphs double-yud (Unicode Character “װ” (U+05F0) ; Name: Hebrew Ligature Yiddish Double Vav) and double-vov (Unicode Character “ײ” (U+05F2) ; Name: Hebrew Ligature Yiddish Double Yod), primarily used for Yiddish, such that nikud that's supposed to be centered under a character get put under the second subletter of the digraph. So a nikud like pasekh, tsere, segol, et al, is centered under the 2nd yud of double-yud and under 2nd vov of double-vov. That's wrong. Nikud is supposed to be centered with respect to both elements of the digraph. That's how these work. That's the whole point of why you need these digraphs. If you wanted the nikud centered under the second character of the digraph, you wouldn't need a digraph: you'd put out two separate characters with the nikud following the second character in the character sequence and unambiguously intended to be centered under that second character.

Here's a sample text for which I'll attach a screen shot of Google Fonts preview showing wrong rendering: װֶעלְכֶע | װֶעלְן | זײַן | רײַך

Google Fonts David Libre - bad double-yud and double-vov digraphs - Screen Shot 2023-03-28 at 9 56 39 AM

@markhdavid
Copy link
Author

This issue is very similar to issue fontef/frankruhllibre#16 for Frank Ruhl Libre, filed by the same author, yours truly. That issue led to the related issue google/fonts#6062 in Google Fonts, which yielded insightful commentary by @simoncozens and related fruitful discussion on the Glyphs App discussion board, here: https://forum.glyphsapp.com/t/yiddish-ligatures-should-not-be-considered-ligatures/25468

markhdavid added a commit to markhdavid/david-libre that referenced this issue Mar 28, 2023
meirsadan#17)

Change double-yud, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE YOD (ײ),
and double-vov, aka U+05F0 HEBREW LIGATURE YIDDISH DOUBLE VAV (װ), to
correct horizontal placement under them of Hebrew diacritic ("nikud"),
as follows:

(1) set subCategory explicitly to "Other", based on advice by
@simoncozens in a Google Fonts issue here:
google/fonts#6062

and

(2) add "bottom" anchors, positioned as follows:

  - Y pos is 0;

  - X pos is halfway between where the "bottom" anchor of each
    component character glyph G would be if laid side by side,
    computed as

      (X pos of "bottom" anchor of G
       + set width of G
       + X pos of "bottom" anchor of G)
      divided by 2

All changes are reflected in this new version of

  sources/DavidLibre.glyphs

Note: this was hand-tested by generating just a few font files and
viewing in FontBook, but I leave it to upstream developers to perform
the the full build based on this source change.
meirsadan added a commit that referenced this issue Jun 25, 2023
Change glyph names to -hb Glyphs standard
Change qamats to "qamats qatan" form #16
Fix misplaced nikkus under Yiddish ligatures #17
Add dlig feature for Yiddish ligatures - vav vav, yod vav, yod yod and yod hiriq
Add final kaf with dagesh, sheva and qamats forms
@meirsadan
Copy link
Owner

Hi,
This issue has been fixed, thanks for posting it. Please check updated versions in this repo.

@markhdavid
Copy link
Author

markhdavid commented Jun 27, 2023

Tested updated fonts for this issue using InDesign on my Mac. Looks good. New fonts incorporated changes in commit e5edc8d.

@davelab6
Copy link
Contributor

Great work both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants