Added a mask icon for Safari pinned tab and touchbar #1706
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the mask-icon to OctoPrint. Safari uses this icon, as well as the color, to display an image in pinned tabs and the touchbar. Apple's docs explaining this are here: https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/pinnedTabs/pinnedTabs.html
With this change it just looks a little nicer to have OctoPrint as a pinned tab or a favorite site in the touchbar.
I made this icon just by tracing a png because the new icon needs to be a black and transparent svg. If anyone already has an svg of the OctoPrint icon I'd be happy to replace it.
Before as a pinned tab:
After as a pinned tab:
On the left is the new touchbar icon for favorites, and the right is the old one. As you can see, the new icon matches more the expected style of other sites.