Skip to content

@W-19628153: [Android][QRCode] When Auth Config "Use the native browser for user authentication on Android" is enabled users logging in via QR code still challenged with browser login #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

@W-19628153: [Android][QRCode] When Auth Config "Use the native browser for user authentication on Android" is enabled users logging in via QR code still challenged with browser login #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,8 @@ open class LoginActivity : FragmentActivity() {
with(SalesforceSDKManager.getInstance()) {
// Fetch well known config and load in custom tab if required.
fetchAuthenticationConfiguration {
if (isBrowserLoginEnabled) {
/* Browser-based authentication is applicable when not authenticating with a front-door bridge URL */
if (isBrowserLoginEnabled && !viewModel.isUsingFrontDoorBridge) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the front door bridge URL will sign the user in automatically, there's no need to display the native browser for username and password authentication if the view model indicates a front door bridge is in use. Note, this property on the view model is only set for the lifetime of a single front door bridge login event.

Copy link
Contributor

@brandonpage brandonpage Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that note, it preempted the question I was going to ask. 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 You asked the same question on the previous pull request. We're creatures of habit!

if (useWebServerAuthentication) {
viewModel.loginUrl.value?.let { url -> loadLoginPageInCustomTab(url, customTabLauncher) }
} else {
Expand Down
Loading