Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade vscode-languageclient to 8.1.0 #5207

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

mingxuanzhangsfdx
Copy link
Member

@mingxuanzhangsfdx mingxuanzhangsfdx commented Nov 3, 2023

What does this PR do?

Downgrades vscode-languageclient to 8.1.0 to be compatible with vscode ^1.67.0 (April, 2022)

What issues does this PR fix or reference?

@W-14366425@

Functionality Before

vscode-languageclient is 9.0.1, which requires ^1.82.0 (August, 2023).

Functionality After

vscode-languageclient is 8.1.0, which requires ^1.67.0 (April, 2022).

@mingxuanzhangsfdx mingxuanzhangsfdx requested a review from a team as a code owner November 3, 2023 18:26
Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Passes my QE
* Starts (no errors) ✅
* Auto-completion ✅
* Hover documentation ✅
* Go to definition ✅
* Anonymous Apex auto-completion ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants