fix: replace deprecated node FS prop W-19160014 #1607
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "devDepOverrides": ["mocha"], | ||
| "wireit": { | ||
| "compile": { | ||
| "clean": "if-file-deleted", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ | |
| "devDependencies": { | ||
| "@jsforce/jsforce-node": "^3.10.3", | ||
| "@salesforce/cli-plugins-testkit": "^5.3.39", | ||
| "@salesforce/dev-scripts": "^11.0.3", | ||
| "@types/deep-equal-in-any-order": "^1.0.1", | ||
| "@types/fast-levenshtein": "^0.0.4", | ||
| "@types/graceful-fs": "^4.1.9", | ||
|
|
@@ -52,6 +52,7 @@ | |
| "deep-equal-in-any-order": "^1.1.19", | ||
| "esbuild": "^0.25.8", | ||
| "eslint-plugin-sf-plugin": "^1.20.30", | ||
| "mocha": "^11.7.1", | ||
| "mocha-junit-reporter": "^1.23.3", | ||
| "mocha-snap": "^5.0.0", | ||
| "ts-morph": "^24.0.0", | ||
|
|
@@ -209,5 +210,8 @@ | |
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "resolutions": { | ||
| "@types/node": "18.19.123" | ||
|
There was a problem hiding this comment. we bumped these types in dev-script: forcedotcom/dev-scripts#388 but there's another |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ const registriesFromPresets = fs | |
| .filter((file) => !file.name.endsWith('CustomLabelsBeta.json')) | ||
| .map((file) => ({ | ||
| name: file.name, | ||
| registry: JSON.parse(fs.readFileSync(path.join(file.parentPath, file.name), 'utf-8')) as MetadataRegistry, | ||
|
There was a problem hiding this comment. the previous
|
||
| })) /* | ||
| decomposedPermissionSetBeta2 has an invalid registry configured. | ||
| this is because multiple children will map to the .objectSettings suffix, and currently, the registry only supports 1:1 suffix mapping | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mocha v10 has a bug when loading TS files via a node loader:
mochajs/mocha#5314
after fixing the types in SDR we still get those wrong warnings:
this change overrides the version of mocha provided by dev-scripts so we can use mocha v11 here, see:
https://github.com/forcedotcom/dev-scripts/?tab=readme-ov-file#config-file-notes
related:
oclif/core#1416