Skip to content

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Mar 21, 2022

requires forcedotcom/sfdx-core#547 and a core bump to not break rest deploys

What does this PR do?

breaking because

  1. removed method on registryAccess for apiVersion
  2. componentSet.getObject and componentSet.getPackageXml are now async
  3. throws sfError instead of sfdxError

removes the hardcoded apiVersion from registry

behavior change: package.xml will always have a version. If the componentSet isn't given one, SDR will make a callout to get the current version from the metadata coverage report.

this will break all the plugin-source NUTs

What issues does this PR fix or reference?

@W-10809897@

@mshanemc mshanemc requested review from a team as code owners March 21, 2022 14:29
@mshanemc mshanemc requested a review from jeffb-sfdc March 21, 2022 14:29
Copy link
Member

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good

mshanemc and others added 6 commits March 25, 2022 12:18
@mshanemc mshanemc changed the title Sm/no hardcoded api version Sm/parking-orbit Mar 29, 2022
@mshanemc mshanemc requested a review from RodEsp March 31, 2022 16:49
mshanemc and others added 2 commits May 2, 2022 09:46
* feat: use core errors and messages, test changes from v5 main

* chore: auto-update metadata coverage in METADATA_SUPPORT.md
@shetzel shetzel merged commit ec55d33 into main May 20, 2022
@shetzel shetzel deleted the sm/no-hardcoded-apiVersion branch May 20, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants