Add page_view model #1985
Add page_view model #1985
Conversation
|
|
||
| // page view | ||
| if (ArticleElement && tokenMeta && !isBot) { | ||
| var randomNumber = Math.floor(Math.random() * 10); // 1 in 10; Only track 1 in 10 impressions |
There was a problem hiding this comment.
Why don't you want to track all views?
There was a problem hiding this comment.
I suppose that it's done for optimization, to make fewer requests and db writes. For unauthorized users, only one of each 10 requests will be saved, but the count will be 10 (https://github.com/thepracticaldev/dev.to/pull/1985/files#diff-a71fed5e724b3cd9cce62138dfb4d631R10), so the number of views will remain approximately the same as if every request was tracked.
There was a problem hiding this comment.
Yup, that’s the logic. We can adjust things later, but this should be a bit less resource costly and give us good enough insights.
| // page view | ||
| if (ArticleElement && tokenMeta && !isBot) { | ||
| var randomNumber = Math.floor(Math.random() * 10); // 1 in 10; Only track 1 in 10 impressions | ||
| if (!checkUserLoggedIn() && randomNumber != 1) { |
There was a problem hiding this comment.
I suggest transforming this condition to smth like if !(checkUserLoggedIn() || randomNumber == 1), in my opinion it's easier to understand.
…to ben/add-pageviews-for-articles
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
This feature adds custom tracking of page views from within the app to complement and compare against Google Analytics data. This should make initial reporting faster and more reliable.
This also opens up the opportunity to show users their history.