Merge latest mozilla code to fork #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llection button. Check now considers selected tab tray mode.
…n until something has been changed set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
…uppression count.
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
Running locally, I get the same error: I think that there legitimately was an reduction in the number of StrictMode suppressions on start up.
…la-mobile#15733) Co-authored-by: Tiger Oakes <toakes@mozilla.com>
This changes the error highlighting from being the entire contents of <Button ...> to just the first line of <Button>.
…ping to delete a tab
… grid view in the tabs setting
… Desktop Bookmarks folder (mozilla-mobile#15649) For mozilla-mobile#15497: Remove and disable the three dot menu button
…le (mozilla-mobile#15667) For mozilla-mobile#15402: Hide ETP pop-up when top or bottom toolbar is not visible
Margins were also adjusted to maintain relative placements.
…logic of startup time for cold, warm, and hot startup types.
Download the built apksYou can download the apks built by Github actions after the CI checks pass. Note that you will have to click on the "Android build PR" tab on the left side to see the artifacts.
|
|
The failing build is just signing that is failing. Which is concerning, as it may mean our CI signing process is flaky or is not working again! The code itself is fine, so I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest mozilla code has added a "grid tab tray" layout taking code from my work here. I had to get rid of most of it as it duplicates our feature and does it in a different way, and the layout is in my opinion not as great.
Pull Request checklist
To download an APK when reviewing a PR:
The PR runs an Android build check (
run-build) that builds aforkReleasevariant of the app. If it succeeds, then we upload the apks (signed with debug keys) via Github actions. We also generate a comment with some instructions and a link to help you find the downloads. You can also follow the instructions below: