Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent sql injection through the ids of the blog comments #3497

Conversation

carakas
Copy link
Member

@carakas carakas commented Mar 23, 2022

Type

  • Security

Pull request description

Prevent SQL injection through the ids on the comments marked as spam in the bulk action

@carakas carakas added this to the 5.11.1 milestone Mar 23, 2022
@carakas carakas requested a review from a team March 23, 2022 12:33
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #3497 (6aca30e) into master (1b38e33) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #3497   +/-   ##
=========================================
  Coverage     27.88%   27.88%           
  Complexity     8145     8145           
=========================================
  Files           575      575           
  Lines         30691    30691           
=========================================
  Hits           8557     8557           
  Misses        22134    22134           
Flag Coverage Δ
functional 23.78% <0.00%> (ø)
installer 3.84% <0.00%> (ø)
unit 7.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Backend/Modules/Blog/Engine/Model.php 45.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b38e33...6aca30e. Read the comment docs.

@carakas carakas merged commit 1bf9d13 into forkcms:master Mar 23, 2022
@carakas carakas deleted the prevent-sql-injection-on-marking-comments-as-spam-for-blog branch March 23, 2022 18:23
@carakas carakas added Blog security Pull requests that address a security vulnerability labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blog security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants