Skip to content

Conversation

jodavies
Copy link
Collaborator

@jodavies jodavies commented Jul 4, 2025

This fixes #615 , but not the other "mode" of sum (TYPESUMFIX), i.e. if we have something like sum $sumind,1,2,3,4;.

I am not sure yet how to fix things in that case: it is inside the call of Generator here

if ( Generator(BHEAD termout,level) ) goto GenCall;

where we need to repeat the statements of the repeat block, right? The term we started with disappears. Setting RepCount before or after the call of Generator here doesn't work.

@coveralls
Copy link

coveralls commented Jul 4, 2025

Coverage Status

coverage: 50.875% (+0.01%) from 50.861%
when pulling 8974af9 on jodavies:repeat-sum
into 8c9e36e on form-dev:master.

If Sum changed the term, set RepCount so that the action is repeated
in a Repeat environment.
@jodavies
Copy link
Collaborator Author

jodavies commented Jul 9, 2025

Updated to add a test. I'll merge this, with the caveat that the sum $sumind,1,2,3,4; mode of sum still doesn't work. Fixing this can be investigated separately. There are anyway ways to "workaround" this in a FORM script.

@jodavies jodavies merged commit 84d86a0 into form-dev:master Jul 9, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour of repeat?
2 participants