Skip to content

fix: memory leak in par=2 EndSort #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix: memory leak in par=2 EndSort #691

merged 1 commit into from
Jul 15, 2025

Conversation

jodavies
Copy link
Collaborator

@jodavies jodavies commented Jul 9, 2025

If a par=2 EndSort ends in the PObuffer, don't allocate and copy out of it twice.

@jodavies
fix: memory leak in par=2 EndSort
4a17a2c 
If a par=2 EndSort ends in the PObuffer, don't allocate and copy
out of it twice.
@jodavies
Copy link
Collaborator Author

jodavies commented Jul 9, 2025

This is related to #644 and the follow-up #684 .

Updated to add a test, which leaks memory on the current master branch.

@coveralls
Copy link

coveralls commented Jul 9, 2025 •
edited
Loading

Coverage Status

coverage: 50.869% (+0.02%) from 50.849%
when pulling 4a17a2c on jodavies:endsort-leak
into 1c83035 on form-dev:master.

@jodavies jodavies merged commit 25d6346 into form-dev:master Jul 15, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jodavies @coveralls