Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to reflect changes from Refactor #7

Closed
ericf opened this issue Aug 15, 2014 · 0 comments · Fixed by #12
Closed

Update README to reflect changes from Refactor #7

ericf opened this issue Aug 15, 2014 · 0 comments · Fixed by #12
Milestone
v1.0.0

Comments

@ericf
Copy link
Collaborator

ericf commented Aug 15, 2014

…also state the best practices for messages. We should change the example with getMyMessage(), because it hard codes a locale-specific string into the React component. Ideally, all such message strings would be externalized from the React components.
@ericf ericf added this to the v1.0.0 milestone Aug 15, 2014
@ericf ericf mentioned this issue Aug 18, 2014
Closed
ericf added a commit to ericf/react-intl that referenced this issue Aug 18, 2014
@ericf
Update README to reflect changes from refactor
fe68dfc 
Closes formatjs#7
@ericf ericf mentioned this issue Aug 18, 2014
Merged
@ericf ericf closed this as completed in #12 Aug 19, 2014
redonkulus pushed a commit that referenced this issue Apr 30, 2019
@marcesengel
Merge pull request #7 from T-TraX/feature/new-context-api
90aaf7a 
Use char code for escaping to fix broken tests.
longlho added a commit that referenced this issue Apr 27, 2020
@longlho
rm browser field from intl-messageformat-parser package.json (#15)
502cc9a 
fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Update README to reflect changes from refactor ericf/react-intl
1 participant
@ericf