Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8264
Description
Checkbox and selectboxes components that are required will treat
false
as a falsy value. In other words, if the component (or one of its constituents) is not checked and that component is required, it is not a valid submission. Other components (e.g. container, data map, select, radio buttons) can havefalse
as a value and not be treated as invalid, which was not accounted for in the required validation rule. This PR tightens required validation by:hidden
property is true;false
a falsy value unless the component is a checkbox or a selectboxes component;Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
added tests
Checklist: