Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8264: update validate required #88

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8264

Description

Checkbox and selectboxes components that are required will treat false as a falsy value. In other words, if the component (or one of its constituents) is not checked and that component is required, it is not a valid submission. Other components (e.g. container, data map, select, radio buttons) can have false as a value and not be treated as invalid, which was not accounted for in the required validation rule. This PR tightens required validation by:

  • not evaluating at all if the component's hidden property is true;
  • not considering false a falsy value unless the component is a checkbox or a selectboxes component;
  • recursively iterating over object values to ensure nested components don't suffer from the same problem; and
  • adding minor updates to the Radio component type.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

added tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@AlexeyNikipelau AlexeyNikipelau merged commit 7ada46f into master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants