Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-4112: Integrate @formio/core validation engine to renderer + many other code cleanup. #5575

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

travist
Copy link
Member

@travist travist commented Apr 22, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-4112

Description

This change refactors the validation engine to use @formio/core validator.

Dependencies

This PR depends on latest 2.x of @formio/core.

How has this PR been tested?

A bunch of automated tests already include tests for the renderer.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit f96bf94 into master Apr 23, 2024
3 checks passed
@brendanbond brendanbond deleted the fio-4112 branch April 23, 2024 15:03
@brendanbond brendanbond restored the fio-4112 branch April 23, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants