Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8389: Fix EditGrid with Empty/Is Not Empty conditional logic in there #5612

Closed

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8389

Description

What changed?

Previously, formio.js would fail to call 'isEmpty' method if it doesn't exist. This PR adds a check to make sure it exists, before calling.

Dependencies

@formio/core:98

How has this PR been tested?

I added automated tests to cover conditionals cases in Edit Grid with Text field and Checkbox components, corresponding to the scenario where this bug was uncovered.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we discuss this? This issue was also reported by an additional customer, but it seems to me this doesn't solve the root cause of the problem (because it is unsolvable? how does the conditional logic know which row is empty?).

@mikekotikov mikekotikov marked this pull request as draft May 31, 2024 14:08
@mikekotikov
Copy link
Contributor Author

Closing, since another PR is made to fix this

@mikekotikov mikekotikov closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants