(fix): revert #130's breaking change of tsconfig options #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why this change was made in that PR as it was unrelated to
the rest, but it broke some things related to Babel usage and maybe
other things
tslib
instead of adding babel helper functionsadd a comment of why it seems like the target is overridden to esnext
since very early versions of TSDX, see feat: Add success/failure hooks to watch #130 comments
Fixes #413 . EDIT: Also fixes #412
Whether TS should transpile to target or Babel should is a good question to raise, but for now this just reverts the breaking change.
Should probably document in the README that
tsconfig
target is ignored and that users should use Babel'spreset-env
to configure the target instead.Should also probably add more tests around this as bugs / breaking changes like this in TSDX's build output can have ripple-effects on libraries using it (vs. the other commands don't affect output, so the impact is limited to just library authors as opposed to library users).