Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a project with package.json without name causes all entries to not be clickable #117

Open
tkodev opened this issue Jul 6, 2017 · 3 comments
Labels

Comments

@tkodev
Copy link

tkodev commented Jul 6, 2017

Where is the configuration directory to remove the project manually? That way I can confirm the bug

I can't remove the entry from the app because entries aren't clickable

@tkodev
Copy link
Author

tkodev commented Jul 12, 2017

Refined problem: Clicking all entries with names work right up until I click the one without the name, at that point nothing works.

screen shot 2017-07-12 at 10 35 59 am

@stefanjudis
Copy link
Member

stefanjudis commented Jul 20, 2017

Hey there. :)

Sorry for the late reply. Can you open the devtools CMD+ALT+I and post the error there. I assume your cms project, doesn't have a package.json?

The settings file should be here ~/Library/Application Support/Forrest/electron-settings/npm-app.json.

@tkodev
Copy link
Author

tkodev commented Jul 22, 2017

It's alright, it does have one but it's just missing a name field. Malformed json in that way but it's out of my control, though temporarily adding a name doesn't change anything in forrest.

The following is what happens when I click the package with the missing name.

build.js:25 undefined
build.js:25 Uncaught TypeError: Cannot read property 'path' of undefined
activate @ build.js:25
Ce @ build.js:6
mountComponent @ build.js:8
(anonymous function) @ build.js:8
(anonymous function) @ build.js:8
...

No errors are thrown clicking the other packages afterwards, though they don't work.

In any case, thanks for the help and providing the settings directory ! That is sufficient enough for me to delete it and be careful next time. Though, having your app gracefully fail is never a bad thing :)

@DanielRuf DanielRuf added the bug label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants