-
Notifications
You must be signed in to change notification settings - Fork 21
Updated CMake build and set of Github Actions mimicking the stdlib
package
#57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace the original `cmake` build system with one mimicking the `stdlib` one. - Replace the original set of Github Actions with those from `stdlib` for consistency.
Add code coverage
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
If it's ok with every body, I'll merge this PR early next week as I have another on its way wherein I've modernized some the implementations leading to almost at 30% speed-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many modified files, but the tests passed, so it looks great, thanks for this PR. A 30% speed improvement sounds really nice.
Yep many files indeed. I'll break the next ones in smaller successive PR to ease the review process, starting with:
I'll go ahead and merge this one. |
I'm very grateful to @jacobwilliams for starting out this modernization of the
fftpack
library. However, with the developments that have happened withstdlib
over the past couple of years, I feel like we should go one step further. This PR is the first of an upcoming series aiming at bringingfftpack
up to the same quality and performance level asstdlib
. It contains the following changes:CMake
build now closely parallels that ofstdlib
(withfypp
being turned off for the moment).meson
build system has been removed for now for the sake of simplicity but can be added back eventually if users ask for it.stdlib
, including:CI.yml
: combination of unix-based OS andgfortran
orintel
compilersCI_windows.yml
: usesmsys2-build
for Windowsfpm-deployment
: deploys a dedicatedfpm
branch (if we followstdlib
with the main branch being dedicated to the rawfypp
files andCMake
build) along with code coverage (viacodecov
)PR-review.yml
: simple action looking for misspelling.The next few PRs will focus on further modernizing the existing code base (usage of
do concurrent
wherever appropriate, modules and submodules, etc). Note that I already started modernizing thezfft
anddfft
and get up a 1.3x speed-up simply by using somedo concurrent
facilitating the compiler's optimizations of certain loops.As I ain't sure who is actively following this repo, I'll ping the
linalg
crew for now @perazz, @jvdp1 and @jalvesz.