Skip to content

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented May 10, 2022

Fixes #62

Adds rudimentary hover support for hovering over associate blocks

TODO:

  • Support slices of existing AST nodes, currently the associate node
    inherits the keywords from the link_obj so the slices display
    the wrong dimensions.
  • Support literals, given that Fortran literals are not currently
    registered as AST nodes it is difficult to provide information on
    the fly without creating more spaghetti code (see current literals).
    The only elegant solution I can think of is parsing the literals as
    AST nodes.

gnikit added 2 commits May 10, 2022 09:55
Fixes #62

Adds rudimentary hover support for hovering over associate blocks

TODO:
- Support slices of existing AST nodes, currently the associate node
   inherits the keywords from the link_obj so the slices display
   the wrong dimensions.
- Support literals, given that Fortran literals are not currently
   registered as AST nodes it is difficult to provide information on
   the fly without creating more spaghetti code (see current literals).
   The only elegant solution I can think of is parsing the literals as
   AST nodes.
@gnikit gnikit changed the title Gnikit/issue62 Hover on associated blocks does not display types May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #107 (e624a9f) into master (8565d4b) will increase coverage by 0.08%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   84.87%   84.95%   +0.08%     
==========================================
  Files          11       11              
  Lines        4363     4374      +11     
==========================================
+ Hits         3703     3716      +13     
+ Misses        660      658       -2     
Impacted Files Coverage Δ
fortls/parse_fortran.py 87.73% <ø> (ø)
fortls/objects.py 81.74% <95.65%> (+0.28%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@gnikit gnikit merged commit c7c3a76 into master May 10, 2022
@gnikit gnikit deleted the gnikit/issue62 branch May 10, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover on associated blocks does not display types
1 participant