-
-
Notifications
You must be signed in to change notification settings - Fork 51
extended list of keywords #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended list of keywords #88
Conversation
Nice job @JHenneberg and thanks for the PR. Don't worry about the unittests I can fix them |
Do you have a link for the doc? From some quick googling I was only able to find this https://j3-fortran.org/doc/year/18/18-007r1.pdf |
Yeah thats the one I got. Edit: I am willing to update all keywords descriptions to this document if you prefer this approach. |
@JHenneberg I am having a look now to see if the changes would be too many |
The problem with using the standard to update the keywords is that the keyword description is very obscure so we would ultimately have to go back to either GCC or Intel for a concise description |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 84.34% 84.29% -0.05%
==========================================
Files 11 11
Lines 4363 4363
==========================================
- Hits 3680 3678 -2
- Misses 683 685 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I am also fine with leaving it for now like this because of the workload. But if I would start from scratch I always would do it vendor inspecific. |
I would not say that it is vendor specific. We still look at the standard when updating the keywords, it's a matter of clarity. This
is a lot clearer than this
if GCC had an equally easy to access online doc of attributes I would probably use that instead |
NOTE: Coarray autocompletion works but signature_help does not trigger past the completion point because the statements are fundamentally not functions.
Is this done @JHenneberg ? |
I have nothing to add. |
Awesome, thanks for all the help. I also read the standard and added (hopefully) all the missing statements. |
acc. to. Intel oneAPI Develeoper (p. 2246) for consistency. I left out the vendor specific keywords
AUTOMATIC
andSTATIC
.Probably it is better to switch to a not vendor specific document for refernce for example
ISO_1539-1_Fortran_Standart_2018