Run failed: Comment on the pull request and push the PR preview to the gh-pages branch - master

[certik]

Every time I comment on a pull request such as: #295, I get an email with the above title and a link to:

https://github.com/fortran-lang/fortran-lang.org/actions/runs/1086966949

It seems something in the CI is broken.

[certik]

I keep getting these emails after every (?) comment I post in this repository. Here is an example:

First such email is from July 31, 2021. Last one is from a couple minutes ago. So far I got 14 of them.

CC @milancurcic, @awvwgk, @LKedward. Do any of you also get these emails?

[milancurcic]

So far I believe I got only 2, but I may have only written 2 comments. Let's see if I get one for this comment.

[milancurcic]

Yes, I just got another one. This started with the merging of #297.

[certik]

I dread to post another comment, as I will get another email. Thanks @milancurcic for confirming. Yes, it looks like #297 caused it, so that should help in figuring out a fix.

[awvwgk]

Do any of you also get these emails?

No, I reduced my GitHub notification emails to the absolute minimum and I'm still getting like ~50 a day. Failing job emails are like 100% noise in my inbox.

The issue is that the two-stage workflow for building the build preview will trigger on every comment event in this repository. The first stage will skip if the required phrase is not part of the comment body. But apparently the second stage will always trigger regardless. It either has to check the comment body as well and skip, only get triggered on successful first stage or be able to fail gracefully.

This check stops workflows from running in the first stage:

fortran-lang.org/.github/workflows/buildPRPreview.yml

Line 22 in 66ed1d4

if: github.event.issue.pull_request && contains(github.event.comment.body,'#build_preview')

While the event used here seems to always evaluate to a true value

fortran-lang.org/.github/workflows/commentAndPushPRPreview.yml

Lines 24 to 26 in 66ed1d4

	if: >
	${{ github.event.workflow_run.event == 'issue_comment' &&
	github.event.workflow_run.conclusion == 'success' }}

[awvwgk]

Please checkout the preview workflow on the new repository, this seems to be resolved there.