Skip to content

PRs script updates #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2021
Merged

PRs script updates #284

merged 4 commits into from
Jul 8, 2021

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Jun 29, 2021

Fixes #283

  • removed attempted optimization that was causing merged PRs to be missed when a previously merged PR had another "update" after being merged
    • unfortunately, it doesn't seem to currently be possible to sort by merge date in the API request
  • for now, the whole list of merged PRs is searched, which takes a few minutes
    • with progress bars if tqdm installed
  • PR titles on new line in the generated Markdown
  • sort merged PRs by merge date (earliest merged -> first in the output list)

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @zmoon - changes look good to me and it works nicely as expected 👍

@milancurcic
Copy link
Member

Thanks, @zmoon!

@milancurcic milancurcic merged commit 03d9371 into fortran-lang:master Jul 8, 2021
@zmoon zmoon deleted the prs branch November 16, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRs script issue
3 participants