Resolves Issue #217 - #369
Conversation
Missing "e" in "WG5: International Fortran Standards Committe" to Missing "e" in "WG5: International Fortran Standards committee" it might seem a little odd for a spelling mistake but i wanted to contribute. thanks and regards, Henil Panchal
Resolves issue fortran-lang#361 Updates spelling-mistakes
Typo in fortyxima fortran-lang#248
Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
Typo -- "running" not "runnning" (2 not 3 n's) at https://fortran-lang.org/learn/quickstart/arrays_strings .
Resolves spelling mistake mentioned in fortran-lang#304
I have made a function that does the Regex and Resolves the issue for c++. Thanks and Regards, Henil Panchal
Resolves Issue fortran-lang#217
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217. Thanks and Regards, Henil Panchal
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217. Thanks and Regards, Henil Panchal
I have made the changes that would handle all regex and this also solves the Issue fortran-lang#217. Thanks and Regards, Henil Panchal
I have made changes that would handle all package search regex and this also solves the Issue fortran-lang#217. Thanks and Regards, Henil Panchal
|
#build_preview |
|
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/ |
|
this works perfectly and also resolves all problems in the #217 thus I request the collaborators to merge the pull request. Thanks and Regards, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@henilp105 Thanks for sharing. Be assured we haven't overlooked or forgotten your contribution. We will have a look as soon as time permits. |
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Many thanks for looking into this @henilp105 - this is a clever solution, unfortunately I think we should fix this at the input stage by properly escaping characters in the input string with something like encodeURIComponent. This will be more robust, since it uses the GET parameters correctly, and will be more understandable/maintainable by future contributors.
|
#build_preview |
|
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/ |
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Many thanks Henil @henilp105, this all looks good to me! 👍 I've just left a few minor comments to cleanup.
Co-authored-by: Laurence Kedward <laurence.kedward@bristol.ac.uk>
|
#build_preview |
|
This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/ |
|
Great stuff, many thanks Henil! |
|
#delete_preview |
|
The preview build for this PR has now been deleted. |
3 participants
I have made changes that would handle all search package regex and this also solves the Issue #217.
Thanks and Regards,
Henil Panchal