-
Notifications
You must be signed in to change notification settings - Fork 68
add string array to learn #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the example to show how this string array is passed to another function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. This is a useful addition to the learn section. Beside one question, this looks good to me.
- should we trim the strings in the printout to show how to deal with trailing whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, great addition. I left a few suggestions.
yep, noticed that too - I was wondering why the code didn't change - let me
fix that.
…On Mon, Mar 21, 2022 at 1:12 PM Milan Curcic ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In learn/quickstart/arrays_strings.md
<#381 (comment)>
:
> @@ -149,3 +149,34 @@ program allocatable_string
end program allocatable_string
```
+
+## Array of strings
+
+The length of all strings in the array must be the same. The length assigned is typically the length of the longest element.
Good catch, thanks. I noticed that you resolved the suggestions without
committing them. Did you mean to do that?
—
Reply to this email directly, view it on GitHub
<#381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFSLSMU4CMIB5WLFSSRHLVBC3ZXANCNFSM5P6B5M4A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Andre
|
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented the suggestion by Sebastian.
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Great, I'll go ahead and merge, thank you again. |
No description provided.