Skip to content

add string array to learn #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 29, 2022
Merged

Conversation

freevryheid
Copy link
Contributor

No description provided.

@awvwgk awvwgk added the learn Related to the learning resources label Mar 4, 2022
@freevryheid
Copy link
Contributor Author

Update the example to show how this string array is passed to another function.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. This is a useful addition to the learn section. Beside one question, this looks good to me.

  • should we trim the strings in the printout to show how to deal with trailing whitespace?

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great addition. I left a few suggestions.

@freevryheid
Copy link
Contributor Author

freevryheid commented Mar 21, 2022 via email

freevryheid and others added 3 commits March 21, 2022 13:28
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the suggestion by Sebastian.

freevryheid and others added 2 commits March 29, 2022 13:06
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
@milancurcic
Copy link
Member

Great, I'll go ahead and merge, thank you again.

@milancurcic milancurcic merged commit be10cec into fortran-lang:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
learn Related to the learning resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants