Skip to content

fix dependency of include files under learn/building_programs mini-book #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

p-costa
Copy link
Collaborator

@p-costa p-costa commented Apr 24, 2022

I had to do this fix to the dependencies generator, to be able to build a project in the case when the makefile is not in the same directory as the source files. I hope this makes sense!

I had to do this fix to the dependencies generator, to be able to build a project in the case when the makefile is not in the same directory as the source files. I hope this makes sense!
@p-costa p-costa requested a review from awvwgk April 24, 2022 10:02
@p-costa p-costa changed the title fix dependency of include files fix dependency of include files under learn/building_programs mini-book Apr 24, 2022
@p-costa
Copy link
Collaborator Author

p-costa commented Apr 24, 2022

(I just noticed that I accidentally did not fork the project... I hope this is fine, else I can close and re-submit a proper PR)

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

If you are on it already, could you mend the regex above to also include zeros? [a-zA-Z][a-zA-Z0-9_] instead of [a-zA-Z][a-zA-Z1-9_]?

@awvwgk
Copy link
Member

awvwgk commented Apr 24, 2022

I'm surprised this is actually used, I wrote this guide to show how involved the makefile setup can become and motivate people to use fpm or other high-level build systems with proper Fortran support ;).

@p-costa
Copy link
Collaborator Author

p-costa commented Apr 24, 2022

I'm surprised this is actually used, I wrote this guide to show how involved the makefile setup can become and motivate people to use fpm or other high-level build systems with proper Fortran support ;).

fpm will come first for me! But I also want to update my naive build workflow using make with this nice and robust one.

@awvwgk awvwgk merged commit 35e0663 into master Apr 24, 2022
@awvwgk awvwgk deleted the rev-make branch April 24, 2022 10:34
@awvwgk awvwgk added bug Something isn't working learn Related to the learning resources labels Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working learn Related to the learning resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants