Skip to content

Increase test coverage of fpm manifest #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2020
Merged

Increase test coverage of fpm manifest #171

merged 4 commits into from
Sep 15, 2020

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Sep 12, 2020 •
edited
Loading

  • should yield complete coverage for all reachable lines in manifest modules (total test coverage at ~78%)
  • info procedures of the manifest types are not tested
  • adds description, keywords, categories and homepage to allowed keys in root (see Support registry meta-data fields in manifest #165)
  • fixes revision -> rev in dependency table
  • fixes path not excluding tag, rev and branch entry
  • fixes grammar of error messages
  • bump commit to latest toml-f version (doesn't require class(toml_table), pointer anymore, bugfixes)
  • include test number in fpm-test runs

Question: Do we want keep the info procedures for the manifest types? I added them for debugging in the first implementation.

Fixes #173

@awvwgk
Increase test coverage of fpm manifest
1ce1f26 
- should yield complete coverage for all reachable lines in manifest
- adds description, keywords and categories to allowed keys in root
- fixes revision -> rev in dependency table
- fixes path not excluding tag, rev and branch entry
- fixes grammar of error messages
- bump commit to latest toml-f version
LKedward
LKedward approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good! 👍 .
I'd very much like to keep the info routines if possible; once the CLI is implemented we should have one or more verbose flag options for debugging the different stages of fpm.

@awvwgk awvwgk mentioned this pull request Sep 13, 2020
Closed
@awvwgk awvwgk marked this pull request as ready for review September 14, 2020 18:01
everythingfunctional
everythingfunctional approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like seeing all these tests, especially for "failure" cases. Thanks! :)

@milancurcic milancurcic merged commit e6c5e6a into fortran-lang:master Sep 15, 2020
@awvwgk awvwgk deleted the manifest-testing branch September 15, 2020 18:51
@awvwgk awvwgk mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@milancurcic milancurcic milancurcic approved these changes

@LKedward LKedward LKedward approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

toml-f implementation produces error if more than 15 test or app programs are used

5 participants

@awvwgk @certik @everythingfunctional @milancurcic @LKedward