Two new options: --keep-blank-lines and --disable-indent-subroutine #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [](https://travis-ci.com/pseewald/fprettify) [](https://coveralls.io/github/pseewald/fprettify?branch=master) [](http://www.gnu.org/licenses/gpl-3.0) [](https://badge.fury.io/py/fprettify) | ||
|
|
||
| fprettify is an auto-formatter for modern Fortran code that imposes strict whitespace formatting, written in Python. | ||
| This is a fork of [pseewald/fprettify](https://github.com/pseewald/fprettify), |
There was a problem hiding this comment.
@zaikunzhang you probably didn't mean to include changes to README in this PR.
There was a problem hiding this comment.
Oh, I'm one of those people that could really use the --keep-blank-lines option, for that I contribute to some projects where (many) consecutive blank lines between subroutines are pervasively used (and expected in contributions, at least preserved).
@zaikunzhang, thank you very much for the proposal, can you remove the committed edit to the README, so that the PR could be merged (and hopefully the PyPi version bumped)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for developing this great package.
In the current version, fprettify removes the consecutive and trailing blank lines. However, some programmers may like to keep those lines. Therefore, it might be a good idea to introduce a new option for such a possibility. This is what "--keep-blank-lines" for.
The idea of "--disable-indent-subroutine" is similar to that of "--disable-indent-mod". It disables the indentation for the body of a subroutine or a function.
Thank you for your consideration, and again, for this very useful software.