Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the examples #63

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Modernize the examples #63

merged 6 commits into from
Mar 15, 2022

Conversation

jacobwilliams
Copy link
Member

@jacobwilliams jacobwilliams commented Mar 13, 2022 •
edited

Fixes #62

@codecov
Copy link

codecov bot commented Mar 13, 2022 •
edited

Codecov Report

Merging #63 (0ce2ed7) into main (e26542b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           2        2           
  Lines        1221     1221           
  Branches      456      456           
=======================================
  Hits         1084     1084           
  Misses         40       40           
  Partials       97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26542b...0ce2ed7. Read the comment docs.

@jacobwilliams jacobwilliams changed the title WIP: Modernize the examples Modernize the examples Mar 13, 2022
@jacobwilliams
Copy link
Member Author

Ready to merge. Really just cosmetic changes so they match the same style as the other tests.

awvwgk
awvwgk approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

certik
certik reviewed Mar 13, 2022
View reviewed changes
examples/example_primes.f90 Outdated Show resolved Hide resolved
@jacobwilliams @certik
Update examples/example_primes.f90
0ce2ed7 
Co-authored-by: Ondřej Čertík <ondrej@certik.us>
@jacobwilliams jacobwilliams merged commit 4717189 into fortran-lang:main Mar 15, 2022
@jacobwilliams jacobwilliams deleted the 62-modernize-examples branch March 15, 2022 01:59
@awvwgk awvwgk added this to the v2.0.0 milestone Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik left review comments

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Modernize the examples
3 participants
@jacobwilliams @certik @awvwgk