Skip to content

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented May 24, 2020

No description provided.

@jvdp1 jvdp1 requested review from certik, zbeekman and milancurcic May 24, 2020 15:09
@certik
Copy link
Member

certik commented May 24, 2020 via email

@jvdp1
Copy link
Member Author

jvdp1 commented May 25, 2020

I think the CoC should stay in the root location for better visibility and also GitHub I think links to it from the UI in some circumstances.

I inserted a note about the CoC in the first page.

@certik
Copy link
Member

certik commented May 25, 2020

Ah, my bad -- I thought you moved the CoC file from the root directory, but you only moved the one from doc/ directory (I did the initial review from my phone). However, your small note that you added at the main API page helps, I think it fits there.

So +1 to merge as is.

Copy link
Member

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jvdp1!

@zbeekman zbeekman merged commit 699c134 into fortran-lang:master May 26, 2020
@jvdp1 jvdp1 deleted the docreag branch June 9, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants