logger: avoid trailing spaces when writing line 2+ #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Carelessness. Its easy to miss a fencepost such as this. |
No problem. I should have noted it during my review ;) I saw it now because I am testing the logger in some of our programs. |
milancurcic
approved these changes
Oct 30, 2020
|
Good. Thank you for the confirmation. Since it is a small issue, I will merge it. |
|
Its good to see someone using it. Let me know if you find any other bugs or features that should be added.
… On Oct 30, 2020, at 10:51 AM, Jeremie Vandenplas ***@***.***> wrote:
Carelessness. Its easy to miss a fencepost such as this.
No problem. I should have noted it during my review ;) I saw it now because I am testing the logger in some of our programs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APTQDOXV4GBLI2BWTVUY57TSNLVITANCNFSM4TFFSKWQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a trailing space will be present from the second line (there is no trailing space for the first line (see
format_fist_linefor details).This PR avoids trailing spaces from the second line.
@wclodius2 What is on purpose that a trailing space remained from the second line?