Skip to content

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 22, 2021

This patch will be part of a series of patches to improve the overall developer documentation.

The current contributing guidelines are quite focused on the workflow and are IMO missing a more general entry point for new contributors. This patch adds an adjusted version of the fpm contributing guidelines as such a more general contributing guideline.

Related issue: #351, fortran-lang/fpm#158, fortran-lang/fpm#160

- adds an adjusted version of the fpm contributing guidelines
@awvwgk awvwgk added documentation Improvements or additions to documentation meta Related to this repository labels Mar 22, 2021
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to be merge from my side after considering minor issues! Thank you.

awvwgk and others added 2 commits April 8, 2021 20:29
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Apr 18, 2021
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, thanks. I only found and corrected one small grammar issue.

@milancurcic milancurcic merged commit af9efe3 into fortran-lang:master May 1, 2021
@awvwgk awvwgk deleted the contributing branch May 1, 2021 15:05
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation meta Related to this repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants