Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize build toolchain workflow and implied rules #360

Merged
merged 2 commits into from Apr 18, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 22, 2021

This patch will be part of a series of patches to improve the overall developer documentation.

The build tools are currently undocumented, this patch is an effort to summarize the developer workflow required to interact with the CMake and make build toolchains. It also attempts to summarize the implied rules for those toolchains by inspection of the build files, the commit history and the issue tracker. This process is not perfect due missing internal knowledge of almost a year on those files and might have resulted in a wrong perception on some of the implied rules. Feedback of previous contributors to those files is welcome.

Related to #351

@awvwgk awvwgk added the documentation Improvements or additions to documentation label Mar 22, 2021
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fr these explanations. Here are some comments

WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
WORKFLOW.md Outdated Show resolved Hide resolved
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Apr 17, 2021
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really useful explanation of the build system for newcomers. LGTM 👍

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Apr 17, 2021
@awvwgk
Copy link
Member Author

awvwgk commented Apr 18, 2021

Thanks for the feedback. I'll go ahead and merge.

@awvwgk awvwgk merged commit ac0f957 into fortran-lang:master Apr 18, 2021
@awvwgk awvwgk deleted the building-workflow branch April 18, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants