copy the test datafiles for test_loadtxt #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdp1
approved these changes
Dec 26, 2019
ivan-pi
approved these changes
Dec 26, 2019
|
+1 to merge
…On Thu, Dec 26, 2019, at 10:13 AM, Ivan wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#48?email_source=notifications&email_token=AAAFAWAE6SX6PH2DEVLANUTQ2TQ2DA5CNFSM4J7L4VX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQH2X5A#pullrequestreview-336571380>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWAUFN33ATSB4X2CXOLQ2TQ2DANCNFSM4J7L4VXQ>.
|
Merged
|
As a new PR, can someone please submit tests for out of tree builds? And also for the Make buildsystem.
…On Thu, Dec 26, 2019, at 4:33 PM, Milan Curcic wrote:
Merged #48 <#48> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#48?email_source=notifications&email_token=AAAFAWBT3NM45H3KE55FTDLQ2U5OJA5CNFSM4J7L4VX2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVX76GQ#event-2909798170>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWB46LXRSKG7C3WEQEDQ2U5OJANCNFSM4J7L4VXQ>.
|
|
I only tested it locally. I will take some time in the next few days to learn how GitHub Actions work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the test to run in an out-of-source build tree.
Works by copying the test data to
${CMAKE_CURRENT_BINARY_DIR}.