Skip to content

Fix string concat #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2021
Merged

Fix string concat #543

merged 3 commits into from
Oct 1, 2021

Conversation

Carltoffel
Copy link
Member

Found a bug in string_type concat where lhs and rhs were the wrong way around. Added proper tests and fixed it.

ivan-pi
ivan-pi approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@ivan-pi ivan-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

awvwgk
awvwgk approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

aman-godara
aman-godara reviewed Oct 1, 2021
View reviewed changes
@milancurcic @aman-godara
Added test cases for empty character scalars
e24a925 
Co-authored-by: Aman Godara <34789087+Aman-Godara@users.noreply.github.com>
@Carltoffel
Copy link
Member Author

Nice addition! I wonder if the char // char test is necessary, since an intrinsic operator is tested here.

@milancurcic
Copy link
Member

Thanks!

@milancurcic milancurcic merged commit 0bf8fd2 into fortran-lang:master Oct 1, 2021
@Carltoffel Carltoffel deleted the fix-string-concat branch October 11, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-pi ivan-pi ivan-pi approved these changes

@awvwgk awvwgk awvwgk approved these changes

+1 more reviewer

@aman-godara aman-godara aman-godara left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Carltoffel @milancurcic @ivan-pi @awvwgk @aman-godara