Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes related to fypp prepocessing #758

Merged
merged 8 commits into from Jan 9, 2024
Merged

Minor changes related to fypp prepocessing #758

merged 8 commits into from Jan 9, 2024

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Jan 7, 2024

Minor changes inspired by #675 and #743

@jalvesz : I believe that this would be a cleaner solulion to the issue your faced with fpm-deployment.sh and test_mean_f03.fypp.

@jvdp1 jvdp1 requested review from awvwgk, a team and arteevraina January 7, 2024 20:56
awvwgk
awvwgk approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks like a reasonable change to include in stdlib.

@jvdp1
Copy link
Member Author

jvdp1 commented Jan 9, 2024

Thank you @awvwgk. As there are minor changes, I will merge it.

@jvdp1 jvdp1 merged commit d89a6e2 into fortran-lang:master Jan 9, 2024
17 checks passed
@jvdp1 jvdp1 mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@arteevraina arteevraina Awaiting requested review from arteevraina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvdp1 @awvwgk