Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lk -> llk in *sytrd_sy2sb #812

Merged
merged 1 commit into from
May 13, 2024
Merged

lk -> llk in *sytrd_sy2sb #812

merged 1 commit into from
May 13, 2024

Conversation

perazz
Copy link
Contributor

@perazz perazz commented May 11, 2024

Fix #810 @jvdp1 @sscalpone

Renaming this variable rather than the logical kind would minimize the number of changes to the code.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @perazz . Could you remof the hidden file, please?
Should we create a new release v0.6.1 after merging this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file, please?

@perazz
Copy link
Contributor Author

perazz commented May 12, 2024

Should we create a new release

I wouldn't think this is a critical update as it is more a standard compliance issue rather than a bug. If however there is a need to have that versioned to allow for broader compiler usage, then it may be worth?

@sscalpone
Copy link

Thanks for the change. It compiles fine in my sandbox.

@jvdp1
Copy link
Member

jvdp1 commented May 13, 2024

Thank you @perazz . I will generate a new version v0.6.1, just to avoid that users try to compile the latest version (v0.6.0) and report the same error multiple times.

@jvdp1 jvdp1 merged commit 1dc58c9 into fortran-lang:master May 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonstandard forward reference to 'lk' is not allowed in the same specification part causes compilation errors
3 participants