Bug/nested case select #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for simple case-select. Use https://github.com/dparkins/language-fortran as a guideline
for type-select constructs.
for rank-select constructs.
|
@pedro-ricardo Have you had a chance to look at this? It would be great if we could merge it to master. |
|
Yes, I've tested it for |
pedro-ricardo
approved these changes
Feb 5, 2021
|
@krvajal @pedro-ricardo If all is okay then, can I merge or do you want me to add this to CHANGELOG? |
|
Yes please |
|
I have pushed the latest changes to my fork but for some reason GitHub thinks that my fork is based on another repo and not this one. I suspect it rebased my fork when this repo went private. I will try and fix this but in of chance I can't get it to work I will close this PR and open a new one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181 .
I tested locally and it works fine although it would be great if we could add some unittests for it to not break again.