fix(cov): hitting mocha timeout creates wrong cov #629
Conversation
|
@fortran-lang/admins I have send an access request to enable codecov, do you think we can give it a shot. |
|
codecov is enabled in Fortran-lang already, I added this repository to the list of repos it is available on. |
Cheers @awvwgk |
|
The request is for private repo access, do we need this for @fortran-lang? |
nope, I think that was a mistake from my end. |
|
@awvwgk Can you see vscode-fortran-support on your
I think the request was for private repos + modifying public repos which I guess includes creating and uploading cov stats |
|
I think codecov is safe to have installed by default for the whole organization rather than only a dedicated repo list. Also approved the request for additional permissions (we don't have any private repos in the org anyway). |
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
=======================================
Coverage ? 68.28%
=======================================
Files ? 11
Lines ? 2103
Branches ? 203
=======================================
Hits ? 1436
Misses ? 665
Partials ? 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fixes #613 Hitting mocha timeout creates false coverage reports, that leads to `c8` reporting false statistics.
gnikit
force-pushed
the
gnikit/issue613
branch
from
597469f to
b862706
Compare
Hitting the timeout in mocha unittesting leads to
c8creating erroneous coverage reports
Fixes #613