Skip to content

Conversation

microsoftly
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 1, 2018

Pull Request Test Coverage Report for Build 16248eca-c488-4607-95a5-b8fd9e8b1b48-b9beaef413d59c80fadb5761116d49c9543f235d

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.549%

Totals Coverage Status
Change from base Build 1947: 0.0%
Covered Lines: 460
Relevant Lines: 1294

💛 - Coveralls

Copy link
Member

@zlav zlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes here look to be in line with the coveralls guidelines. My understanding is that this code essentially tells Coveralls which previous coverage runs to merge into a single code coverage report. Just so I understand going forward, the goal of this change is to have the ability to run unit and integration tests in parallel and be able to see the combination of their coverage. The goal is not to be able to see different coverage reports for unit and integration tests correct?

@microsoftly
Copy link
Contributor Author

@zlav that is correct. That being said, goveralls does not currently have support for parallel jobs. I'm closing this for now until we build the needed support

@microsoftly microsoftly closed this Oct 3, 2018
@microsoftly microsoftly reopened this Oct 3, 2018
@elldritch elldritch force-pushed the test/multipleCoverage branch from ba74b70 to f3c7a64 Compare October 5, 2018 23:18
@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@58b0fb7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #306   +/-   ##
=========================================
  Coverage          ?   42.27%           
=========================================
  Files             ?       56           
  Lines             ?     2493           
  Branches          ?        0           
=========================================
  Hits              ?     1054           
  Misses            ?     1335           
  Partials          ?      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b0fb7...50d4613. Read the comment docs.

@elldritch elldritch force-pushed the test/multipleCoverage branch from b05a8a4 to 57fbe04 Compare October 8, 2018 08:06
Copy link
Contributor

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @microsoftly's offline LGTM.

@microsoftly microsoftly merged commit e432486 into master Oct 8, 2018
@microsoftly microsoftly deleted the test/multipleCoverage branch October 8, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants