-
Notifications
You must be signed in to change notification settings - Fork 185
feat(circle.yml) aggregate coverage for multiple reports within a single PR #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 16248eca-c488-4607-95a5-b8fd9e8b1b48-b9beaef413d59c80fadb5761116d49c9543f235d
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes here look to be in line with the coveralls guidelines. My understanding is that this code essentially tells Coveralls which previous coverage runs to merge into a single code coverage report. Just so I understand going forward, the goal of this change is to have the ability to run unit and integration tests in parallel and be able to see the combination of their coverage. The goal is not to be able to see different coverage reports for unit and integration tests correct?
@zlav that is correct. That being said, |
ba74b70
to
f3c7a64
Compare
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=========================================
Coverage ? 42.27%
=========================================
Files ? 56
Lines ? 2493
Branches ? 0
=========================================
Hits ? 1054
Misses ? 1335
Partials ? 104 Continue to review full report at Codecov.
|
…that depends on the previous steps completing
b05a8a4
to
57fbe04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @microsoftly's offline LGTM.
No description provided.